Add support for Int32# and Word32#
AcceptedPublic

Authored by Abhiroop on Aug 1 2018, 11:34 AM.

Details

Summary

This diff adds support for Int32# and Word32#. It depends on D4475 and D5006 for the 8 bit and 16 bit Int and Word types respectively.

NOTE: This involves a change in the binary package which need to be merged along with this.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
int8-new
Lint
Lint WarningsExcuse: will fix later
Unit
No Unit Test Coverage
Build Status
Buildable 22107
Build 51054: [GHC] Linux/amd64: Continuous Integration
Build 51053: [GHC] OSX/amd64: Continuous Integration
Build 51052: [GHC] Windows/amd64: Continuous Integration
Build 51051: arc lint + arc unit
Abhiroop created this revision.Aug 1 2018, 11:34 AM
Abhiroop updated this revision to Diff 17545.Aug 1 2018, 10:34 PM
  • Fix the type constructor function for Int32 and Word32
  • Add more tests for Int32# and Word32#
Abhiroop retitled this revision from [WIP] Add support for Int32# and Word32# to Add support for Int32# and Word32#.Aug 1 2018, 10:36 PM
Abhiroop edited the summary of this revision. (Show Details)
bgamari accepted this revision.Sep 27 2018, 1:33 PM

Hi @Abhiroop,

Thanks for doing this! This looks quite good; I'm happy to merge as-is.

This revision is now accepted and ready to land.Sep 27 2018, 1:33 PM

@bgamari Thanks for accepting this.

Just as a reminder, there is a related change in the binary package which needs to land along with this.

https://github.com/Abhiroop/packages-binary/commit/ba9349bf2e05b90b7741df371a4ee273fe891d39