Simplify lintIdUnfolding
ClosedPublic

Authored by mpickering on Mon, Jul 2, 8:37 AM.

Details

Summary

The logic for DFunUnfolding seemed quite confusing and unecessary. A
simpler strategy uses maybeUnfoldingTemplate, as that is what is
actually used when doing inlining and checking that has the right type.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mpickering created this revision.Mon, Jul 2, 8:37 AM
bgamari accepted this revision.Mon, Jul 2, 3:40 PM

Indeed, much better.

This revision is now accepted and ready to land.Mon, Jul 2, 3:40 PM

Fine, module one suggestion.

compiler/coreSyn/CoreLint.hs
662

I'd put the isStableUnfolding first

mpickering updated this revision to Diff 17166.Tue, Jul 3, 4:22 AM
  • Simon's suggestion
This revision was automatically updated to reflect the committed changes.