circleci: Detect core count
ClosedPublic

Authored by bgamari on Jun 26 2018, 8:12 PM.

Details

Summary
Test Plan

Try ./validate, CircleCI build; make sure core count detection works in both cases.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bgamari created this revision.Jun 26 2018, 8:12 PM
bgamari updated this revision to Diff 17100.Jun 26 2018, 8:13 PM

Make executable

bgamari updated this revision to Diff 17102.Jun 26 2018, 8:18 PM

Fix name of thing

I triggered a build against my circle ci integration, through phab's build step interface. Let's see how it goes: https://circleci.com/gh/alpmestan/ghc/15 (previously, it'd just blow up, trying to build and run things with -j9 on a 2 core box with 4GB of RAM).

alpmestan accepted this revision.Jun 28 2018, 4:48 PM

It looks like switching to the ghc-diffs repo you created as a "staging" one for the Circle CI builds did the trick. Not sure how important the core detection logic was in making this work, but I suppose it is anyway better not to just blindly run with -j9.

I triggered a build from the phabricator interface, which resulted in this successful Circle CI build: https://circleci.com/gh/ghc/ghc-diffs/11
The Phab side is here: https://phabricator.haskell.org/harbormaster/build/48987/ -- it is not yet rich in information about the build, but this is also the very first build that succeeds in this setup.

This revision is now accepted and ready to land.Jun 28 2018, 4:48 PM
This revision was automatically updated to reflect the committed changes.