Show addresses of live objects in GHCi leak check
ClosedPublic

Authored by osa1 on Jun 25 2018, 8:02 AM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
osa1 created this revision.Jun 25 2018, 8:02 AM
osa1 updated this revision to Diff 17083.Jun 25 2018, 8:22 AM
  • Mask tag bits

Cool :)

ghc/GHCi/Leak.hs
71

Why don't we have access to ghc-prim? Do we just need to add it as a dependency? Why not do that?

osa1 added inline comments.Jun 25 2018, 1:52 PM
ghc/GHCi/Leak.hs
71

I wasted an entire hour today trying to add ghc-prim as a dependency to ghc package but I failed. It's already a dependency transitively (via base), but it was impossible for me to find all the necessary places in our pile of makefiles to update. If anyone knows which files to update I'm happy to do it.

osa1 added inline comments.Jun 27 2018, 2:32 AM
ghc/GHCi/Leak.hs
71

It seems like no one knows how to add a dependency to the ghc package...

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2018, 2:38 AM
This revision was automatically updated to reflect the committed changes.
simonmar added inline comments.Jun 27 2018, 3:33 AM
ghc/GHCi/Leak.hs
71

Don't you just add it to Build-Depends in ghc/ghc-bin.cabal.in? (I'm a bit confused because you said the ghc package, did you really mean the ghc-bin package?)

I'd really like to avoid an unnecessary unsafeCoerce here.

osa1 added inline comments.Jun 27 2018, 4:24 AM
ghc/GHCi/Leak.hs
71

I didn't even know that there are two packages: ghc and ghc-bin. Adding it to ghc-bin.cabal.in works. Submitted D4901.