Fix for built-in Natural literals
AbandonedPublic

Authored by hsyl20 on Jun 20 2018, 7:14 AM.

Details

Reviewers
hvr
bgamari
Trac Issues
#15286
Summary

This patch implements a workaround to avoid a GHC build error due to built-in Natural in a specific case (see Trac #15286).

hsyl20 created this revision.Jun 20 2018, 7:14 AM
bgamari requested changes to this revision.Jun 20 2018, 8:26 AM

I'm okay with this sort of solution for now, but it really needs more documentation.

libraries/base/GHC/Num.hs
6

Do you understand specifically why this helps? I'm okay introducing a hack like this, but I'd like to understand (and document) what we are doing, why, and why we believe it avoids the original issue.

This revision now requires changes to proceed.Jun 20 2018, 8:26 AM
hsyl20 added inline comments.Jun 20 2018, 9:49 AM
libraries/base/GHC/Num.hs
6

Sadly not. I totally agree but we'll need to investigate more.

hsyl20 updated this revision to Diff 17049.Jun 22 2018, 6:41 AM
  • Create a separate diff for the desugaring bug
hsyl20 edited the summary of this revision. (Show Details)Jun 22 2018, 6:41 AM

hadrian doesn't need this patch anymore indeed, and I believe this was the only motivation for this patch -- can you confirm @hsyl20?

hsyl20 abandoned this revision.Sep 28 2018, 10:29 AM

hadrian doesn't need this patch anymore indeed, and I believe this was the only motivation for this patch -- can you confirm @hsyl20?

Yes it was!