Set -O2 via NoFibHcOpts instead of individual Makefiles.
ClosedPublic

Authored by AndreasK on Jun 11 2018, 3:31 AM.

Details

Reviewers
bgamari
jmct
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rNOFIBa3b0f2b2cff8: Set -O2 via NoFibHcOpts instead of individual Makefiles.
Summary

We set -O2 in NoFibHcOpts which is then applied to all benchmarks run.

Adding -O2 in individual benchmarks is therefore redundant.
It also leads to issues when testing performance flags via
EXTRA_HC_OPTS.
Individual Makefiles attach -O2 last. This means all
flags set by -O2 could not be disabled with -fno-<flag> as they
were reenabled by the later -O2 switch.

Test Plan

Using

Diff Detail

Repository
rNOFIB nofib
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AndreasK created this revision.Jun 11 2018, 3:31 AM
Owners added a reviewer: Restricted Owners Package.Jun 11 2018, 3:31 AM
bgamari accepted this revision.Jun 16 2018, 11:38 AM

Seems reasonable to me.

This revision is now accepted and ready to land.Jun 16 2018, 11:38 AM
This revision was automatically updated to reflect the committed changes.