Add support for FreeBSD arm
ClosedPublic

Authored by murankar on Jun 7 2018, 12:16 PM.

Details

Summary

Add support for FreeBSD arm.

Test Plan

Tested on armv6, armv7 and aarch64 on FreeBSD 12-CURRENT.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
murankar created this revision.Jun 7 2018, 12:16 PM
bgamari requested changes to this revision.Jun 7 2018, 12:20 PM

Looks pretty good to me. That being said, it would be nice if it were more clear *why* we prefer ARM to Thumb.

aclocal.m4
657

Out of curiosity, what is wrong with Thumb on FreeBSD?

This revision now requires changes to proceed.Jun 7 2018, 12:20 PM
murankar added inline comments.Jun 7 2018, 12:33 PM
aclocal.m4
657

Our Thumb support is pretty limited (we don't have Thumb2 for example and we had compiler issues in the past for Thumb).

bgamari accepted this revision.Jun 7 2018, 12:52 PM

Alright, fair enough. Thanks for the clarification!

This revision is now accepted and ready to land.Jun 7 2018, 12:52 PM
This revision was automatically updated to reflect the committed changes.