--show-iface: Always qualify names
AbandonedPublic

Authored by sjakobi on Jun 7 2018, 7:38 AM.

Details

Reviewers
bgamari
Summary

This is the same representation as with -ddump-hi

Test Plan

make test TEST="DocsInHiFile1 Orphans"

sjakobi created this revision.Jun 7 2018, 7:38 AM

I'm not sure I follow why this is an improvement. It seems like this is only introducing noise. Perhaps I'm missing some context?

I'm not sure I follow why this is an improvement. It seems like this is only introducing noise. Perhaps I'm missing some context?

Right, I forgot about the context:

In Hi Haddock, we sometimes get multiple Names from different modules for the same identifier. In order to differentiate them, we want to see their qualified names.

For now, there's probably little benefit from this. Feel free to close this. In that case I'll simply add it to D4749 which was probably the smarter thing in the first place. ;)

I'm not sure I follow why this is an improvement. It seems like this is only introducing noise. Perhaps I'm missing some context?

Right, I forgot about the context:

In Hi Haddock, we sometimes get multiple Names from different modules for the same identifier. In order to differentiate them, we want to see their qualified names.

Perhaps we then need a -dalways-show-module-prefixes to force module qualification? I'm a bit weary of forcing this on all the time.

I think this deserves a proper discussion in a Trac issue, with some background information and concrete motivating examples.

sjakobi abandoned this revision.Jun 13 2018, 7:15 AM

I have created Trac #15269.