Make HsDocString a newtype of ByteString
ClosedPublic

Authored by sjakobi on May 27 2018, 9:03 PM.

Details

Summary

Docstrings don't profit from FastString's interning, so we switch to
a different type that doesn't incur this overhead.

Updates the haddock submodule.

sjakobi created this revision.May 27 2018, 9:03 PM
bgamari accepted this revision.May 27 2018, 9:19 PM

Looks quite reasonable to me.

This revision is now accepted and ready to land.May 27 2018, 9:19 PM
sjakobi added a comment.EditedMay 27 2018, 11:31 PM

Not sure what caused the timeout of T13410 in https://phabricator.haskell.org/harbormaster/build/46363/…

It passes on my local machine.

alexbiehl accepted this revision.May 28 2018, 1:52 AM

LGTM. Thanks Simon!

This revision was automatically updated to reflect the committed changes.