Differential D4743

Make HsDocString a newtype of ByteString
ClosedPublic
Actions

Authored by sjakobi on May 27 2018, 9:03 PM.

Details

Reviewers
alexbiehl
bgamari
Commits
rGHCd1beebb88172: Make HsDocString a newtype of ByteString
Trac Issues
#15157
Summary

Docstrings don't profit from FastString's interning, so we switch to
a different type that doesn't incur this overhead.

Updates the haddock submodule.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sjakobi created this revision.May 27 2018, 9:03 PM
bgamari accepted this revision.May 27 2018, 9:19 PM

Looks quite reasonable to me.

This revision is now accepted and ready to land.May 27 2018, 9:19 PM
sjakobi added a comment.EditedMay 27 2018, 11:31 PM

Not sure what caused the timeout of T13410 in https://phabricator.haskell.org/harbormaster/build/46363/…

It passes on my local machine.

alexbiehl accepted this revision.May 28 2018, 1:52 AM

LGTM. Thanks Simon!

Closed by commit rGHCd1beebb88172: Make HsDocString a newtype of ByteString (authored by sjakobi, committed by bgamari). · Explain WhyMay 30 2018, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcompiler/hsSyn/HsDoc.hs (45 lines)
Mcompiler/parser/Parser.y (10 lines)
Mcompiler/rename/RnHsDoc.hs (2 lines)
Mutils/haddock (2 lines)

Diff 16602

View Options

compiler/hsSyn/HsDoc.hs

Loading...
View Options

compiler/parser/Parser.y

Loading...
View Options

compiler/rename/RnHsDoc.hs

Loading...
View Options

utils/haddock

Loading...