Unmask readMVar in readChan
ClosedPublic

Authored by dfeuer on May 25 2018, 2:52 PM.

Details

Summary

When readMVar was implemented using takeMVar and putMVar,
we needed to use modifyMVarMasked in readChan just in case
the readMVar was interrupted between taking and putting. Now
that readMVar uses an atomic primop, this is impossible, so we can
safely unmask readMVar.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfeuer created this revision.May 25 2018, 2:52 PM
simonmar accepted this revision.May 28 2018, 5:40 AM

Good spot.

This revision is now accepted and ready to land.May 28 2018, 5:40 AM
This revision was automatically updated to reflect the committed changes.