Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try)
ClosedPublic

Authored by niteria on May 14 2018, 4:02 PM.

Details

Summary

See the new note.
This should fix cb5c2fe875965b7aedbc189012803fc62e48fb3f enough
to unbreak Windows and OS X builds.

Test Plan

manual testing with patched gdb

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niteria created this revision.May 14 2018, 4:02 PM
niteria updated this revision to Diff 16419.May 14 2018, 4:04 PM

update comment

bgamari accepted this revision.May 16 2018, 11:39 AM

The comments here are great. Thanks!

The only failures are the stat issues which should now be fixed on master so this looks good to me.

This revision is now accepted and ready to land.May 16 2018, 11:39 AM

I *think* this doesn't break Windows, but I'm still running local tests.

According to local testing this doesn't break more than is currently broken, I will land this.

This revision was automatically updated to reflect the committed changes.