Differential D4607

Fix NUMA support on Windows (#15049)
ClosedPublic
Actions

Authored by KaneTW on Apr 18 2018, 10:06 AM.

Details

Reviewers
bgamari
erikd
simonmar
Commits
rGHC75361b119c60: Fix NUMA support on Windows (#15049)
Summary
  • osNumaNodes now returns the right number of nodes
  • thread affinity is now correctly set

TODO: no noticeable performance improvement.
does windows already distribute threads in a NUMA-aware fashion?

Test Plan
  • validate
  • local tests on a NUMA machine

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
master
Lint
Lint WarningsExcuse: todo
SeverityLocationCodeMessage
Warningrts\win32\OSMem.c:518TXT3Line Too Long
Warningrts\win32\OSThreads.c:582TXT3Line Too Long
Unit
No Unit Test Coverage
Build Status
Buildable 20319
Build 44253: [GHC] Linux/amd64: Continuous Integration
Build 44252: [GHC] OSX/amd64: Continuous Integration
Build 44251: [GHC] Windows/amd64: Continuous Integration
Build 44250: arc lint + arc unit
KaneTW created this revision.Apr 18 2018, 10:06 AM
KaneTW requested review of this revision.Apr 27 2018, 10:49 AM
This revision is now accepted and ready to land.Apr 30 2018, 2:54 AM
bgamari accepted this revision.May 2 2018, 4:37 PM

Looks good to me. Thanks @KaneTW!

Closed by commit rGHC75361b119c60: Fix NUMA support on Windows (#15049) (authored by KaneTW, committed by bgamari). · Explain WhyMay 3 2018, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrts/win32/OSMem.c (23 lines)
Mrts/win32/OSThreads.c (3 lines)

Diff 16079

View Options

rts/win32/OSMem.c

Loading...
View Options

rts/win32/OSThreads.c

Loading...