`--via-asm` only for windows targets
ClosedPublic

Authored by angerman on Mar 5 2018, 3:19 AM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
angerman created this revision.Mar 5 2018, 3:19 AM
bgamari accepted this revision.Mar 5 2018, 2:14 PM

Yes, this looks reasonable to me.

This revision is now accepted and ready to land.Mar 5 2018, 2:14 PM
trofi accepted this revision.Mar 5 2018, 2:21 PM

Looks good! Thank you!

@trofi you might want to still try --via-asm with https://github.com/haskell/hsc2hs/pull/8. It might be faster, as we do not need to do the binary search for constants.
Ideally we'd also extend it to compute all constants in one go, instead of computing each on their own.

Closed by commit rGHCf6cf4001574e: `--via-asm` only for windows targets (authored by Moritz Angermann <moritz.angermann@gmail.com>). · Explain WhyMar 5 2018, 7:26 PM
This revision was automatically updated to reflect the committed changes.