Don't use ld.gold when building libraries for GHCi
ClosedPublic

Authored by simonmar on Feb 21 2018, 8:47 AM.

Details

Summary

ld.gold is buggy when using -r and a linker script. See upstream bug
https://sourceware.org/bugzilla/show_bug.cgi?id=22266

This has been causing various brokenness for the GHC runtime linker,
where we load these broken object files.

Test Plan

Test program from Trac #14675

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
simonmar created this revision.Feb 21 2018, 8:47 AM
bgamari accepted this revision.Feb 21 2018, 8:53 AM

This will do.

This revision is now accepted and ready to land.Feb 21 2018, 8:53 AM
This revision was automatically updated to reflect the committed changes.
osa1 added a subscriber: osa1.EditedFeb 27 2018, 1:44 PM

I just got this error after git pull && ./configure && make: /bin/bash: @LdNoGoldCmd@: command not found which seems to be related with this patch.

bgamari added a comment.EditedFeb 27 2018, 2:00 PM
In D4431#123664, @osa1 wrote:

I just got this error after git pull && ./configure && make: /bin/bash: @LdNoGoldCmd@: command not found which seems to be related with this patch.

You likely need to run ./boot. Also see D4448.