Derive Generic for TH types (#9527)
AbandonedPublic

Authored by austin on Nov 4 2014, 1:07 PM.

Details

Summary

Derive Generic for TH types (Trac #9527)

This also changes the Int# fields of NameFlavour to Int, which
simplifies a bunch of code. TH.Name is not compared much, anyway.

Test Plan

none.

Diff Detail

goldfire updated this revision to Diff 1247.Nov 4 2014, 1:07 PM
goldfire retitled this revision from to Derive Generic for TH types (#9527).
goldfire updated this object.
goldfire edited the test plan for this revision. (Show Details)
goldfire added a reviewer: austin.
goldfire updated the Trac tickets for this revision.
goldfire updated this revision to Diff 1248.Nov 4 2014, 1:47 PM
goldfire edited edge metadata.

Fix build warnings.

goldfire updated this revision to Diff 1252.Nov 4 2014, 3:51 PM

Fix more build problems.

Harbormaster has issued a false positive for errors here.

austin requested changes to this revision.Nov 5 2014, 12:24 PM
austin edited edge metadata.

Awesome. Can you add a minor tidbit to the release notes, under the "Template Haskell" section please?

This revision now requires changes to proceed.Nov 5 2014, 12:24 PM
austin accepted this revision.Nov 5 2014, 12:27 PM
austin edited edge metadata.

Actually, feel free to just do that when you push.

This revision is now accepted and ready to land.Nov 5 2014, 12:27 PM
austin commandeered this revision.Jan 12 2015, 5:34 AM
austin edited reviewers, added: goldfire; removed: austin.
This revision now requires review to proceed.Jan 12 2015, 5:34 AM