Compute the union of imp_finsts on the side
ClosedPublic

Authored by niteria on Feb 2 2018, 10:13 AM.

Details

Summary

I've explained most of the rationale in a new Note.
I'd happily add a test for this, but the difference is only
visible in run time, allocations remain more or less the same.

FWIW running generateModules from Trac #14693 with DEPTH=16, WIDTH=30
finishes in 23s before, and 11s after.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niteria created this revision.Feb 2 2018, 10:13 AM
simonpj accepted this revision.Feb 6 2018, 10:16 AM

Great Note, thank you!

This revision is now accepted and ready to land.Feb 6 2018, 10:16 AM

PS: consider adding the perf-effect summary (from the Phab Description) to the Note:

FWIW running generateModules from Trac Trac #14693 with DEPTH=16, WIDTH=30 finishes in 23s before, and 11s after.

This revision was automatically updated to reflect the committed changes.