Remove unused extern cost centre collection
ClosedPublic

Authored by osa1 on Jan 15 2018, 12:45 AM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
osa1 created this revision.Jan 15 2018, 12:45 AM

AFAIK CostCentre has an Ord instance maybe ordNub makes sense here? (I have no idea about distribution of cost centres)

osa1 added a comment.Jan 15 2018, 1:46 AM

AFAIK CostCentre has an Ord instance maybe ordNub makes sense here? (I have no idea about distribution of cost centres)

This may make sense (CostCentre has an Ord instance) but we need to first add ordNub to one of the utils modules for this.

We already have nubSort, might that be an alternative?

simonmar accepted this revision.Jan 15 2018, 2:38 AM

nubSort would be an improvement too.

This revision is now accepted and ready to land.Jan 15 2018, 2:38 AM
osa1 updated this revision to Diff 15088.Jan 15 2018, 2:46 AM
  • Use nubSort instead of nub
This revision was automatically updated to reflect the committed changes.