Handle CPP properly in Backpack
ClosedPublic
Actions

Authored by ezyang on Nov 24 2017, 11:03 PM.

Details

Reviewers

ekmett
bgamari

Commits

rGHCe1fb28384c44: Handle CPP properly in Backpack

Trac Issues

#14525

Summary

Previously, we attempted to lookup 'hole' packages for
include directories; this obviously is not going to work.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan

validate

Repository

rGHC Glasgow Haskell Compiler

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

...a pity this just missed GHC 8.2.2

This revision is now accepted and ready to land.Nov 27 2017, 8:30 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			compiler/main/Packages.hs (10 lines)
M			testsuite/tests/backpack/cabal/bkpcabal01/p/P.hs.in1 (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14811	c0f2b4f		Nov 24 2017, 11:01 PM	★	★
Diff 2	14867	6998772	rGHCe1fb28384c44fcd29b0e60b9fd44767be22646af	Nov 30 2017, 6:25 PM	★	★