CLabel: Clean up unused label types
ClosedPublic

Authored by bgamari on Nov 12 2017, 12:13 PM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bgamari created this revision.Nov 12 2017, 12:13 PM
trommler requested changes to this revision.Nov 12 2017, 1:15 PM

I built the diff against HEAD on a POWER8 and got this error:

compiler/codeGen/StgCmmPrim.hs:1710:30: error:
    Variable not in scope: mkArrWords_infoLabel :: CLabel

compiler/ghc.mk:446: recipe for target 'compiler/stage1/build/StgCmmPrim.o' failed

It seems some changes are missing in the diff.

This revision now requires changes to proceed.Nov 12 2017, 1:15 PM

I built the diff against HEAD on a POWER8 and got this error:

compiler/codeGen/StgCmmPrim.hs:1710:30: error:
    Variable not in scope: mkArrWords_infoLabel :: CLabel

compiler/ghc.mk:446: recipe for target 'compiler/stage1/build/StgCmmPrim.o' failed

It seems some changes are missing in the diff.

Indeed, sorry about that, @trommler! The change I uploaded was a bit too aggressive. This version compiles for me.

trommler accepted this revision.Nov 14 2017, 11:38 AM

LGTM. I validated this diff applied to HEAD and Phab:D4181 on a POWER8 (powerpc64-linux) with no regressions.

This revision is now accepted and ready to land.Nov 14 2017, 11:38 AM
This revision was automatically updated to reflect the committed changes.