Bump haddock
ClosedPublic

Authored by alexbiehl on Oct 31 2017, 4:44 PM.

Details

Summary

This also enables the new quick jump navigation feature for haddock documentation.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexbiehl created this revision.Oct 31 2017, 4:44 PM
alexbiehl edited the summary of this revision. (Show Details)Oct 31 2017, 4:45 PM

Harbourmaster indicates this regresses spaces/./perf/haddock/haddock.Cabal.run haddock.Cabal. I will have a look when I get home.

alexbiehl planned changes to this revision.Nov 1 2017, 11:34 AM
alexbiehl updated this revision to Diff 14531.Nov 1 2017, 1:27 PM
  • Bump bump

Let's see how this fares!

alexbiehl updated this revision to Diff 14544.Nov 2 2017, 12:37 PM
  • Another bump

I profiled the regression and these are the top consumers:

everythingInRenamedSource Haddock.Backends.Hyperlinker.Ast    utils/haddock/haddock-api/src/Haddock/Backends/Hyperlinker/Ast.hs:26:1-69               26.7   34.4
attachInstances           Haddock.Interface                   utils/haddock/haddock-api/src/Haddock/Interface.hs:94:46-106                            13.8   14.4
tc_rn_src_decls           TcRnDriver                          compiler/typecheck/TcRnDriver.hs:(493,4)-(555,7)                                        13.1    7.0
renderStep                Haddock                             utils/haddock/haddock-api/src/Haddock.hs:187:39-82                                       7.9   11.6
processExport             Haddock.Backends.Xhtml              utils/haddock/haddock-api/src/Haddock/Backends/Xhtml.hs:(666,1)-(680,66)                 4.8    6.8
ppHtmlModule              Haddock.Backends.Xhtml              utils/haddock/haddock-api/src/Haddock/Backends/Xhtml.hs:(534,1)-(562,77)                 3.9    4.5
solve_loop                TcInteract                          compiler/typecheck/TcInteract.hs:(244,9)-(248,44)                                        3.9    1.2
Parser                    HscMain                             compiler/main/HscMain.hs:(316,5)-(384,20)                                                3.2    3.8
deSugar                   HscMain                             compiler/main/HscMain.hs:511:7-44                                                        2.4    1.3
lex'                      Haddock.Backends.Hyperlinker.Parser utils/haddock/haddock-api/src/Haddock/Backends/Hyperlinker/Parser.hs:(43,1)-(47,48)      2.1    2.0
zonkTopDecls              TcRnDriver                          compiler/typecheck/TcRnDriver.hs:(444,16)-(445,43)                                       1.7    1.4
canNC                     TcCanonical                         compiler/typecheck/TcCanonical.hs:(83,5)-(89,45)                                         1.6    1.2
mkMaps.mappings.declDoc   Haddock.Interface.Create            utils/haddock/haddock-api/src/Haddock/Interface/Create.hs:(378,11)-(381,27)              1.4    1.5
tcRnImports               TcRnDriver                          compiler/typecheck/TcRnDriver.hs:240:20-50                                               1.3    0.7
classify                  Haddock.Backends.Hyperlinker.Parser utils/haddock/haddock-api/src/Haddock/Backends/Hyperlinker/Parser.hs:(132,1)-(150,27)    1.2    0.0

This indicates it is not the newly added features but the the old and known everythingInRenamedSource in Hyperlinked source slowness.

Sounds good to me.

This revision was automatically updated to reflect the committed changes.