hWaitForInput-accurate-stdin
Needs ReviewPublic

Authored by syd on Oct 16 2017, 11:06 AM.

Details

Reviewers
nh2
hvr
bgamari
austin
Trac Issues
#8684
Summary

A test that makes sure that 'hWaitForInput' waits for an accurate amount of time.

Test Plan

this _is_ a test

syd created this revision.Oct 16 2017, 11:06 AM
syd added a comment.Oct 17 2017, 9:19 AM

I'm quite unsure why this fails. It doesn't fail locally.

syd updated this revision to Diff 14382.Oct 17 2017, 10:42 PM

Made the legroom 1ms instead of 1s

syd updated this revision to Diff 14388.Oct 18 2017, 10:51 AM

Comment about FILE_TYPE_CHAR

syd planned changes to this revision.Oct 23 2017, 6:59 AM
austin resigned from this revision.Nov 9 2017, 5:46 PM
syd updated this revision to Diff 14795.Nov 24 2017, 7:46 AM

Rebase ontop of master

syd updated this revision to Diff 14796.Nov 24 2017, 8:21 AM

Fixed a > -> >=

syd updated this revision to Diff 14798.Nov 24 2017, 9:12 AM

Fixed the millisecond problem.

nh2 added inline comments.Nov 27 2017, 11:03 AM
libraries/base/tests/hWaitForInput-accurate-stdin.hs
10

needs ... in cmd.exe or PowerShell, otherwise the reader might assume that running it in mintty is also OK, but that doens't trigger the FILE_TYPE_CHAR code path

bgamari requested changes to this revision.Nov 27 2017, 1:02 PM

Hmm, it looks like this failed even on Linux.

This revision now requires changes to proceed.Nov 27 2017, 1:02 PM
syd updated this revision to Diff 14904.Dec 10 2017, 10:00 AM

extra info