GHC_LLVM_TARGET: Keep android OS
ClosedPublic

Authored by angerman on Sep 26 2017, 8:30 AM.

Details

Summary

Our usual GHC_CONVERT_OS macro, will turn any andoird* into android.
This however drops the essential androideabi part. As such for the
GHC_LLVM_TARGET we only convert the VENDOR, not the OS.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
angerman created this revision.Sep 26 2017, 8:30 AM
bgamari requested changes to this revision.Sep 26 2017, 11:05 AM

This deserves a comment at very least.

This revision now requires changes to proceed.Sep 26 2017, 11:05 AM
angerman updated this revision to Diff 14152.Sep 26 2017, 8:20 PM
angerman edited edge metadata.
  • LLVM target, retain -andoird* and -gnueabi*
bgamari accepted this revision.Sep 26 2017, 8:56 PM

Thanks!

This revision is now accepted and ready to land.Sep 26 2017, 8:56 PM
This revision was automatically updated to reflect the committed changes.