Remove special case for tagToEnum# in CG
Changes PlannedPublic

Authored by dfeuer on Sep 16 2017, 12:27 PM.

Details

Summary

We used to need a special case to get rid of tagToEnum# in the
code generator. Now that tagToEnum# is handled in core2core, that
special case now seems to be unreachable code. Remove it, and adjust
notes accordingly.

dfeuer created this revision.Sep 16 2017, 12:27 PM
simonmar requested changes to this revision.Sep 21 2017, 2:53 AM

I'm still quite confused about what happened here, there was some blocker that prevented us from doing this before that seems to have disappeared - what was the blocker and why is it no longer an issue?

Could you do a nofib run as a sanity check before committing this please? If there are any changes at all that would be suspicious, right?

This revision now requires changes to proceed.Sep 21 2017, 2:53 AM
dfeuer planned changes to this revision.Sep 25 2017, 10:55 PM

This isn't ready yet. D4022 failed. The trouble is that we can end up with case-of-tagToEnum# as a result of CorePrep transformations. See that differential for more thoughts.

austin resigned from this revision.Nov 9 2017, 5:39 PM