Differential D3960

base: Add more detail to FD_SETSIZE related error message
ClosedPublic
Actions

Authored by nh2 on Sep 14 2017, 8:52 AM.

Details

Reviewers
bgamari
austin
hvr
Commits
rGHCDIFF022455ffcf01: base: Add more detail to FD_SETSIZE related error message
rGHC022455ffcf01: base: Add more detail to FD_SETSIZE related error message

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nh2 created this revision.Sep 14 2017, 8:52 AM
bgamari requested changes to this revision.Sep 14 2017, 9:20 AM

Good idea. One nit.

libraries/base/cbits/inputReady.c
83

Perhaps we should change this into a barf?

This revision now requires changes to proceed.Sep 14 2017, 9:20 AM
nh2 updated this revision to Diff 13884.Sep 14 2017, 9:30 AM
nh2 edited edge metadata.

Fixed wrong use of arc when updating commit

nh2 updated this revision to Diff 13885.Sep 14 2017, 9:38 AM

Address comment, switching to barf()

nh2 marked an inline comment as done.Sep 14 2017, 9:39 AM
bgamari requested changes to this revision.Sep 14 2017, 9:48 AM
bgamari added inline comments.
libraries/base/cbits/inputReady.c
83

Drop first argument.

This revision now requires changes to proceed.Sep 14 2017, 9:48 AM
nh2 updated this revision to Diff 13887.Sep 14 2017, 10:27 AM
nh2 edited edge metadata.

Fix barf() invocation

nh2 marked an inline comment as done.Sep 14 2017, 10:29 AM
bgamari accepted this revision.Sep 14 2017, 11:16 AM

Looks good to me.

This revision is now accepted and ready to land.Sep 14 2017, 11:16 AM
Closed by commit rGHC022455ffcf01: base: Add more detail to FD_SETSIZE related error message (authored by nh2, committed by bgamari). · Explain WhySep 19 2017, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibraries/base/cbits/inputReady.c (3 lines)

Diff 13988

View Options

libraries/base/cbits/inputReady.c

Loading...