Really fix fft2 regression. #9740
ClosedPublic

Authored by dfeuer on Oct 29 2014, 9:03 AM.

Details

Summary

Rewrite take more aggressively for fusion. Add some more explicit
strictness to unsafeTake and unsafeDrop that seems to help code size and
allocation just a drop in some nofib tests. They were not previously
strict in their numerical arguments, but always called in contexts where
those had been forced; it didn't make a difference in simple test cases,
but made a small difference for nofib.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfeuer updated this revision to Diff 1092.Oct 29 2014, 9:03 AM
dfeuer retitled this revision from to Really fix fft2 regression. #9740.
dfeuer updated this object.
dfeuer edited the test plan for this revision. (Show Details)
dfeuer added reviewers: nomeata, austin.
dfeuer updated the Trac tickets for this revision.
dfeuer edited edge metadata.Oct 29 2014, 9:06 AM
dfeuer added a project: GHC.
nomeata accepted this revision.Oct 29 2014, 9:47 AM
nomeata edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.