Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115
ClosedPublic

Authored by sighingnow on Sep 10 2017, 9:24 AM.

Details

Summary

This patch add newtype deriving instance declarations to make IntPtr and WordPtr as instance of the Data typeclass.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sighingnow created this revision.Sep 10 2017, 9:24 AM
sighingnow updated the Trac tickets for this revision.Sep 10 2017, 9:29 AM
sighingnow edited the test plan for this revision. (Show Details)
RyanGlScott requested changes to this revision.Sep 10 2017, 9:34 AM
RyanGlScott added a subscriber: RyanGlScott.

Thanks for the contribution, @sighingnow! This looks good save for a few minor issues described below.

Please add an entry to libraries/base/changelog.md which describes this change. (Make sure to reference Trac #13115, too.)

libraries/base/Data/Data.hs
1197

Use 4.11.0.0 instead of 4.10.1.0.

This revision now requires changes to proceed.Sep 10 2017, 9:34 AM
sighingnow updated this revision to Diff 13806.Sep 10 2017, 9:39 AM
sighingnow edited edge metadata.
RyanGlScott accepted this revision.Sep 10 2017, 9:42 AM

LGTM, thanks.

(I don't know why Harbormaster is failing to build this, but it's unlikely to be your fault, based on the build output.)

This revision is now accepted and ready to land.Sep 10 2017, 9:42 AM

Thanks for your help, @RyanGlScott.

This revision was automatically updated to reflect the committed changes.