Fix logic error in GhcMake.enableCodeGenForTH
ClosedPublic

Authored by duog on Jul 9 2017, 7:47 PM.

Details

Summary

transitive_deps_set was incorrect, it was not considering the dependencies of
dependencies in some cases. I've corrected it and tidied it up a little.

The test case from leftaroundabout, as linked to from the ticket, is added with
small modifications to flatten directory structure.

Test Plan

make test TEST=T13949

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
duog created this revision.Jul 9 2017, 7:47 PM
alexbiehl accepted this revision.Jul 11 2017, 6:54 AM

Thanks @duog! This looks correct now.

This revision is now accepted and ready to land.Jul 11 2017, 6:54 AM
Closed by commit rGHCea751248d80e: Fix logic error in GhcMake.enableCodeGenForTH (authored by Douglas Wilson <douglas.wilson@gmail.com>, committed by bgamari). · Explain WhyJul 11 2017, 1:53 PM
This revision was automatically updated to reflect the committed changes.