base: Explicitly mark Data.Either.{left,right} as INLINABLE
ClosedPublic

Authored by bgamari on May 12 2017, 10:15 AM.
bgamari created this revision.May 12 2017, 10:15 AM
nomeata accepted this revision.May 12 2017, 10:41 AM
nomeata added a subscriber: nomeata.

LGTM

This revision is now accepted and ready to land.May 12 2017, 10:41 AM

As I just wrote on Trac #13689, I don't think that issue is really "about" rights. It strikes me as a bug that these definitions do not get unfoldings by default; and that bug could affect many similar definitions in user programs.

I don't think lefts and rights are important enough to get this ad-hoc treatment, and I think it sort of sends the wrong message about use of INLINABLE, but I could live with this change, especially if intended as temporary.

A test would be good to have.

dfeuer accepted this revision.May 12 2017, 11:07 AM
This revision was automatically updated to reflect the committed changes.