Allow spliced patterns in pattern synonyms
ClosedPublic

Authored by bgamari on May 11 2017, 10:13 AM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bgamari created this revision.May 11 2017, 10:13 AM
bgamari updated this revision to Diff 12512.May 11 2017, 10:15 AM

Handle finalizers

bgamari updated the Trac tickets for this revision.May 11 2017, 10:47 AM
bgamari updated this revision to Diff 12513.May 11 2017, 10:58 AM

Make it work

bgamari updated this revision to Diff 12514.May 11 2017, 11:00 AM

Fix long line

bgamari updated this revision to Diff 12515.May 11 2017, 11:03 AM

Test separate matcher and builder

bgamari retitled this revision from Try allowing spliced patterns in pattern synonyms to Allow spliced patterns in pattern synonyms.May 11 2017, 11:06 AM
bgamari added reviewers: goldfire, mpickering.
mpickering requested changes to this revision.May 11 2017, 11:33 AM

Could you possible add a test which tries using these pattern synonyms rather than just compiling the file?

This revision now requires changes to proceed.May 11 2017, 11:33 AM

Could you possible add a test which tries using these pattern synonyms rather than just compiling the file?

Sure.

bgamari updated this revision to Diff 12518.May 11 2017, 11:51 AM
bgamari edited edge metadata.

Turn test into should_run

How does this look?

bgamari updated this revision to Diff 12519.May 11 2017, 11:52 AM

Kill errant newline

This revision was automatically updated to reflect the committed changes.