This enables the SpecConst transformation to work
across modules. I mostly copied and modified code from the normal specialiser
and it seems to work. Here to validate and get feedback.
TODO:
| Lint Warnings | Excuse: todo |
| No Unit Test Coverage |
| compiler/specialise/SpecConstr.hs | ||
|---|---|---|
| 719 | Reversing isn't free. Do you really have to do it twice here? | |
| 744 | There's an awful lot of very lazy-looking stuff going on in goEnv. Could you maybe add a comment explaining why we want that, or alternatively why it's less lazy than it looks? Or just remove it: let !(env', bind') = ... !(env'', binds') = ... in ... | |
Thanks for looking David but I'm not sure this patch works properly yet at all. Do you have an idea of a small test I could add?
Matthew, I have not done a detailed review, but it looks as if you are following the pattern in Specialise.hs. Can you write an overview Note explaining the goal, with an example, and pointing to where things happen.
| compiler/specialise/SpecConstr.hs | ||
|---|---|---|
| 1877 | Why wasn't this necessary before? | |