Only build iserv with -threaded if GhcThreaded is set

Authored by rwbarton on Apr 6 2017, 6:46 PM.



By default GhcThreaded is set by

# We can only build GHCi threaded if we have a threaded RTS:
GhcThreaded = $(if $(findstring thr,$(GhcRTSWays)),YES,NO)

so it seems incorrect to try to build iserv with -threaded when
GhcThreaded is not set. This came up when I was building GHC with
some strange combination of flavours (debugged and profiled but not

Test Plan


Diff Detail

rGHC Glasgow Haskell Compiler
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
rwbarton created this revision.Apr 6 2017, 6:46 PM
rwbarton edited the summary of this revision. (Show Details)Apr 6 2017, 7:08 PM
bgamari accepted this revision.Apr 6 2017, 8:04 PM

Have you checked that iserv doesn't break when not threaded?

This revision is now accepted and ready to land.Apr 6 2017, 8:04 PM

Good point. I have not tested that, as I didn't need ghci for what I was doing.

Well, it at very least passes CI. Frankly, perhaps my comment isn't terribly important given that iserv would have been broken anyways on non-threading-capable platforms.

This revision was automatically updated to reflect the committed changes.