Remove GhcDynamic (in favor of DYNAMIC_GHC_PROGRAMS)
ClosedPublic

Authored by rwbarton on Apr 6 2017, 6:41 PM.

Details

Summary

DYNAMIC_GHC_PROGRAMS and GhcDynamic both tried to control whether
the ghc binary was built as a dynamic executable, with confusing
results. In particular, setting GhcDynamic=NO has no effect on
systems where DYNAMIC_GHC_PROGRAMS defaults to YES.

DYNAMIC_GHC_PROGRAMS is more fully-featured (it ensures that the
correct flavor of the libraries is built, for example) so let's
keep it and remove GhcDynamic to reduce confusion.

This effectively reverts commit 3c6190b0.

Test Plan

tested locally; harbormaster

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rwbarton created this revision.Apr 6 2017, 6:41 PM
bgamari accepted this revision.Apr 7 2017, 3:29 PM

It seems like this bears on Trac #10536, no?

Looks good to me.

This revision is now accepted and ready to land.Apr 7 2017, 3:29 PM
This revision was automatically updated to reflect the committed changes.