Save renamed syntax when signature merging.
ClosedPublic

Authored by ezyang on Mar 13 2017, 4:22 AM.

Details

Summary

This is required to make Haddock work correctly.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ezyang created this revision.Mar 13 2017, 4:22 AM
bgamari requested changes to this revision.Mar 13 2017, 1:15 PM

What happens otherwise? Is there a ticket for this? We could certainly use a few more comments.

compiler/typecheck/TcBackpack.hs
500

How will someone reading this code later know what things should be preserved?

This revision now requires changes to proceed.Mar 13 2017, 1:15 PM
ezyang updated this revision to Diff 11723.Mar 13 2017, 4:16 PM
ezyang edited edge metadata.

add more comments

compiler/typecheck/TcBackpack.hs
500

Added more comments.

bgamari accepted this revision.Mar 13 2017, 6:30 PM

Alright, better. Thanks @ezyang!

This revision is now accepted and ready to land.Mar 13 2017, 6:30 PM
This revision was automatically updated to reflect the committed changes.