Fixed QuasiQuotation test and output
Needs RevisionPublic

Authored by ruperthorlick on Mar 8 2017, 10:51 AM.

Details

Summary

Fixed up remaining validation tests

ruperthorlick created this revision.Mar 8 2017, 10:51 AM

What are these tests meant to test? Why does qq006 depend on parsec, that doesn't seem very robust.

It looks like the output changed significantly for all of them.

mpickering added inline comments.Mar 8 2017, 2:26 PM
testsuite/tests/ghci/scripts/ghci014.stdout
1

Also why is this file 2000 lines long?

rwbarton requested changes to this revision.Mar 8 2017, 2:55 PM

I don't know what these tests were supposed to test, but I'm fairly sure that whatever it was is not reflected by the current test behavior.

This revision now requires changes to proceed.Mar 8 2017, 2:55 PM

I agree that these are all a little strange. @bgamari asked me to get them compiling at least, but now I guess we want to figure out what they're actually good for. They were left over broken tests after I validated https://phabricator.haskell.org/D3271.

It looks like the Parsec one didn't compile properly, so I'll go back and look at that again. (Although it is indeed not very robust).

The QuickCheck one I have no idea. Is it worth hunting down the author?

testsuite/tests/ghci/scripts/ghci014.stdout
1

It is run by a script that calls do_test 1000 times! I have no idea why this is a reasonable test.

austin resigned from this revision.Nov 9 2017, 11:34 AM