DmdAnal: Take into account usages in unfoldings
Changes PlannedPublic

Authored by bgamari on Feb 26 2017, 9:47 PM.

Details

Reviewers
austin
Trac Issues
#11126
Summary

This fixes Trac #11126, where a let-binding was inappropriately identified as absent
despite occurring in a stable unfolding. The fix is straightforward: simply
apply the top demand to each of the free variables of the unfolding.

Test Plan

Validate

bgamari created this revision.Feb 26 2017, 9:47 PM
bgamari updated the Trac tickets for this revision.Feb 26 2017, 9:47 PM

Unfortunately this approach regresses one-shot detection. Need to think about this a bit more.

bgamari planned changes to this revision.Mar 2 2017, 3:08 PM
duog added a subscriber: duog.Sep 27 2017, 2:21 PM
duog added inline comments.
Makefile
106 ↗(On Diff #14162)

and this one

testsuite/mk/boilerplate.mk
224 ↗(On Diff #14162)

These changes must be accidental

Good catches, @duog.

bgamari updated this revision to Diff 14175.Sep 27 2017, 7:39 PM

Kill spurious changes

bgamari planned changes to this revision.Oct 3 2017, 2:14 PM

Still need to fix one-shot issue.

austin resigned from this revision.Nov 9 2017, 9:43 AM