Fix configure check for 9439 bug
ClosedPublic

Authored by Yuras on Oct 3 2014, 5:18 AM.

Details

Summary

We should escape path to ghc.On wondows usually ghc comes from HP, which is installed somewhere in "...\Haskell Platform\..." Note space in the middle.

Test Plan

not necessary

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Yuras updated this revision to Diff 769.Oct 3 2014, 5:18 AM
Yuras retitled this revision from to Fix configure check for 9439 bug.
Yuras updated this object.
Yuras edited the test plan for this revision. (Show Details)
Yuras added a reviewer: austin.
Yuras set the repository for this revision to rGHC Glasgow Haskell Compiler.
Yuras added a project: GHC.
rwbarton accepted this revision.Oct 3 2014, 7:40 AM
rwbarton added a reviewer: rwbarton.
rwbarton added a subscriber: rwbarton.

Yes, good catch. LGTM.

hvr accepted this revision.Oct 3 2014, 8:17 AM
hvr added a reviewer: hvr.

Maybe validate could even test for such errors by setting up a symlink inside a directory with a space in its name to $(which ghc)?

austin accepted this revision.Oct 3 2014, 3:07 PM
austin edited edge metadata.

LGTM.

In D304#6957, @rwbarton wrote:

Maybe validate could even test for such errors by setting up a symlink inside a directory with a space in its name to $(which ghc)?

Yeah, ./validate already does something similar with bindisttest I think - it actually creates a directory with spaces and installs to it, and runs a package installation test. But of course, this check is during build time, not install time, so it would need to be replicated there, perhaps...

This revision is now accepted and ready to land.Oct 3 2014, 3:07 PM
This revision was automatically updated to reflect the committed changes.