iserv: Communicate over stdio.
AbandonedPublic

Authored by shlevy on Dec 13 2016, 12:50 PM.

Details

Summary

This simplifies implementation, and is what stdio exists for.

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
iserv-stdio
Lint
Lint WarningsExcuse: Other hook declarations are longer
SeverityLocationCodeMessage
Warningcompiler/main/Hooks.hs:103TXT3Line Too Long
Unit
No Unit Test Coverage
Build Status
Buildable 12556
Build 16459: [GHC] Linux/amd64: Patch building
Build 16458: [GHC] OSX/amd64: Continuous Integration
Build 16457: arc lint + arc unit
shlevy updated this revision to Diff 9947.Dec 13 2016, 12:50 PM
shlevy retitled this revision from to iserv: Communicate over stdio..
shlevy updated this object.
shlevy edited the test plan for this revision. (Show Details)
shlevy added a reviewer: simonmar.

Tests still running locally, just wanted to throw this up for discussion now.

shlevy updated this revision to Diff 9948.Dec 13 2016, 12:58 PM
shlevy edited edge metadata.

Fix bogus reference to command line fd numbers

shlevy updated this revision to Diff 9950.Dec 13 2016, 1:36 PM
shlevy edited edge metadata.

Add missing import

shlevy updated this revision to Diff 9951.Dec 13 2016, 1:40 PM
shlevy edited edge metadata.

Missed variable rename

OK, tests pass.

bgamari edited edge metadata.Dec 13 2016, 2:03 PM

Will this really work? What if the user runs getLine in ghci -fexternal-interpreter?

shlevy abandoned this revision.Dec 13 2016, 2:08 PM

Ah, fair point, I was thinking only about the TH case, obviously this will break common GHCI uses. Damn!