Replace -fshow-source-paths with -fhide-source-paths
ClosedPublic

Authored by hsyl20 on Nov 18 2016, 10:14 AM.

Details

Summary

This patch reverts the change introduced with
587dcccfdfa7a319e27300a4f3885071060b1f8e and restores the previous default output
of GHC (i.e., show source path and object path for each compiled module).

The -fhide-source-paths flag can be used to hide these paths and reduce the line
noise.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
fix-12851
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12021
Build 15367: [GHC] Linux/amd64: Patch building
Build 15366: arc lint + arc unit
hsyl20 updated this revision to Diff 9498.Nov 18 2016, 10:14 AM
hsyl20 retitled this revision from to Replace -fshow-source-paths with -fhide-source-paths.
hsyl20 updated this object.
hsyl20 edited the test plan for this revision. (Show Details)
hsyl20 added reviewers: bgamari, gracjan, hvr, nomeata.
hsyl20 updated the Trac tickets for this revision.
bgamari edited edge metadata.Nov 18 2016, 12:57 PM

If the others on the ticket agree that this is an improvement then this looks fine to me.

However, two things:

  1. Update the users guide (using-warnings.rst IIRC)
  2. Update expected testsuite output
hsyl20 updated this revision to Diff 9522.Nov 21 2016, 2:03 AM
hsyl20 edited edge metadata.
  • Fix tests
  • doc
hvr awarded a token.Nov 21 2016, 9:32 AM
hvr accepted this revision.Nov 21 2016, 9:36 AM
hvr edited edge metadata.

@hsyl20 Thanks for going through the hassle to rework the code yet again!

This revision is now accepted and ready to land.Nov 21 2016, 9:36 AM
This revision was automatically updated to reflect the committed changes.