fix build failure on Solaris caused by usage of --export-dynamic as linker option
ClosedPublic

Authored by kgardas on Oct 17 2016, 6:21 AM.

Details

Summary

This patch fixes build failure on Solaris which is caused
by usage --export-dynamic linker parameter. This parameter is not
supported by Solaris linker. The param itself was added by D2590

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kgardas updated this revision to Diff 9039.Oct 17 2016, 6:21 AM
kgardas retitled this revision from to fix build failure on Solaris caused by usage of --export-dynamic as linker option.
kgardas updated this object.
kgardas edited the test plan for this revision. (Show Details)
kgardas added reviewers: bgamari, simonmar.
simonmar edited edge metadata.Oct 17 2016, 9:05 AM

Thanks and sorry for the breakage!

iserv/ghc.mk
34

Just to clarify: do you mean it exports all the static symbols as dynamic symbols? (that's what --export-dynamic does)

kgardas marked an inline comment as done.Oct 17 2016, 11:55 AM

Yes, probably yes. Honestly speaking I've googled for equivalent option and its need and found this: http://stackoverflow.com/questions/596076/solaris-linker-equivalent-to-the-gnu-ld-export-dynamic-flag -- I've also build on Solaris with the patch and run testsuite and there are no new errors judging form quick look. I've also compared nm iserv|wc -l on Solaris and Linux and found that 31511 and 31123 are pretty similar numbers. I've not investigated more, but if you know some iserv's symbol which you are interested in and which is exported as dynamic one on Linux, I would grep for it here on Solaris for verification. Thanks.

bgamari accepted this revision.Oct 17 2016, 6:09 PM
bgamari edited edge metadata.

Thanks Karel!

This revision is now accepted and ready to land.Oct 17 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.