When looking up flags, we make sure to lookup the non-deprecated flags first by ordering the list.
Hi Martin, looking better.
I will abandon the other differential for you. In future you can update an existing differential
by arc diff --update D2541 in order to avoid creating a duplicate.
Yes, I didn't thought such change could have all those implications.
The thing is that the test cases are incorrect (ish). They reveal the same problem we are trying to solve, they suggest deprecated flags.
I will run all the cases to be sure, and then update this revision.
In case you didn't know, running ./validate from the source tree root will conveniently build and test a set of changes (although sadly it will clean and rebuild your tree so it isn't always desirable). My apologies if you were already aware of this.
Hello bgamari. Thank you very much for your suggestion. I've done that, and given that it takes hours to finish I left the office computer at that.
Tomorrow morning (if all went well) I will update the revision. I am very grateful for your help and time.