compiler: fix trac issue #12574
AbandonedPublic

Authored by mpickering on Sep 23 2016, 10:16 AM.

Details

Reviewers
MartinCeresa
austin
bgamari
Trac Issues
#12574
Summary

Fixes Trac #12574. Reorder flag warning messages.

Signed-off-by: Martin Ceresa <ceresa@cifasis-conicet.gov.ar>

MartinCeresa retitled this revision from to compiler: fix trac issue #12574.
MartinCeresa updated this object.
MartinCeresa edited the test plan for this revision. (Show Details)
MartinCeresa updated the Trac tickets for this revision.

There are a few things wrong here.

  1. It seems there are some unrelated submodule updates which need to be removed .
  2. I explained a more robust way to fix this on the ticket which I think is better than this implementation. Could you explain why you chose to do it this way?
mpickering requested changes to this revision.Sep 23 2016, 10:33 AM
mpickering added a reviewer: mpickering.
This revision now requires changes to proceed.Sep 23 2016, 10:33 AM

Yes, I did not noticed those unrelated submodules updates. I clearly need to do this again.
It seems simpler to separate the current warning flags from the deprecated ones at its definition than check it on flagSpecOf.

If you think the way you suggested it is better, I will do that instead. I not sure all the implications this changes could have.

It's not obviously a better solution but it deserves some discussion. It does have the advantage of being more robust, as we discovered, it is unexpected that the ordering of this list has any impact at all.

mpickering commandeered this revision.Sep 23 2016, 1:04 PM
mpickering abandoned this revision.
mpickering edited reviewers, added: MartinCeresa; removed: mpickering.