hp2ps: fix invalid PostScript for names with parentheses
ClosedPublic

Authored by mst on Jul 11 2016, 2:54 PM.

Details

Summary

The names in the .hp files may contain un-matched opening parentheses,
so escape them.

GHC Trac: Trac #9517

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mst updated this revision to Diff 8189.Jul 11 2016, 2:54 PM
mst retitled this revision from to hp2ps: fix invalid PostScript for names with parentheses.
mst updated this object.
mst edited the test plan for this revision. (Show Details)
mst set the repository for this revision to rGHC Glasgow Haskell Compiler.
mst updated the Trac tickets for this revision.
bgamari accepted this revision.Jul 11 2016, 6:09 PM
bgamari edited edge metadata.

Great point. Thanks!

This revision is now accepted and ready to land.Jul 11 2016, 6:09 PM
austin accepted this revision.Jul 11 2016, 6:53 PM
austin edited edge metadata.

Nice, thank you! This looks fine.

We might want to add a test for this, but OTTOMH I don't know where (it's hard to check on mobile, at the moment). However, this case is relatively "obvious" and very trivial, so for now I'm giving it the green light.

This revision was automatically updated to reflect the committed changes.