Testsuite: use ignore_stderr/stdout instead of ignore_output
ClosedPublic

Authored by thomie on Jun 28 2016, 5:56 AM.

Details

Summary

The problem with ignore_output is that it hides errors for WAY=ghci.
GHCi always returns with exit code 0 (unless it is broken itself).

For example: ghci015 must have been failing with compile errors for
years, but we didn't notice because all output was ignored.

Therefore, replace all uses of ignore_output with either ignore_stderr
or ignore_stdout. In some cases I opted for adding the expected output.

Update submodule hpc and stm.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomie updated this revision to Diff 8082.Jun 28 2016, 5:56 AM
thomie retitled this revision from to Testsuite: use ignore_stderr/stdout instead of ignore_output.
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie added a reviewer: simonmar.
simonmar accepted this revision.Jun 29 2016, 8:24 AM
simonmar edited edge metadata.

Didn't read it all, but the plan sounds like a good idea.

This revision is now accepted and ready to land.Jun 29 2016, 8:24 AM
This revision was automatically updated to reflect the committed changes.