Disable unbuffering of stdout, fixes encoding problem #12213.
AbandonedPublic

Authored by ezyang on Jun 22 2016, 7:59 PM.

Details

Reviewers
austin
bgamari
thomie
Trac Issues
#12213
Summary

This patch is a cheat: a "better" patch would preserve
unbuffering but fix the encoding problem. But we don't
unbuffer on Python 3 anyway, so I don't feel like this
is a big problem.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
ghc-quick2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10200
Build 12246: arc lint + arc unit
ezyang updated this revision to Diff 8039.Jun 22 2016, 7:59 PM
ezyang retitled this revision from to Disable unbuffering of stdout, fixes encoding problem #12213..
ezyang updated this object.
ezyang edited the test plan for this revision. (Show Details)
ezyang added a reviewer: thomie.
ezyang updated the Trac tickets for this revision.
thomie requested changes to this revision.Jun 28 2016, 7:44 AM
thomie edited edge metadata.

I tried this, but you end up with a very confusing intertwining of stdout and stderr.

I need to look into this.

This revision now requires changes to proceed.Jun 28 2016, 7:44 AM
ezyang abandoned this revision.Dec 26 2016, 8:39 PM

Was fixed in a different rev.