Add tests for plugin error messages in stage1
Needs RevisionPublic

Authored by osa1 on Jun 18 2016, 7:52 AM.

Details

Test Plan

Is there a way to remove duplicate files FrontendPluginUser.hs and CorePluginUser.hs?

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
plugin_err_msgs
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10137
Build 12182: arc lint + arc unit
osa1 updated this revision to Diff 7999.Jun 18 2016, 7:52 AM
osa1 retitled this revision from to Add tests for plugin error messages in stage1.
osa1 updated this object.
osa1 edited the test plan for this revision. (Show Details)
osa1 added a reviewer: thomie.
bgamari accepted this revision.Jul 18 2016, 6:31 AM
bgamari edited edge metadata.

Looks reasonable to me.

This revision is now accepted and ready to land.Jul 18 2016, 6:31 AM
thomie requested changes to this revision.Jul 18 2016, 6:47 AM
thomie edited edge metadata.

In FrontendPluginUser, you're passing in a frontend plugin with -fplugin instead of with --frontend (see https://downloads.haskell.org/~ghc/master/users-guide/extending_ghc.html#frontend-plugins). Is that intentional?

Is there a way to remove duplicate files FrontendPluginUser.hs and CorePluginUser.hs?

There is no easy way to do that, the driver looks for <testname>.hs.

testsuite/tests/stage1/Makefile
14

Remove -dynamic. ghcPluginWayFlags will contain -dynamic already, when ghc is compiled with -dynamic.

This test will probably fail on Travis as is.

This revision now requires changes to proceed.Jul 18 2016, 6:47 AM
austin resigned from this revision.Nov 9 2017, 9:32 AM