Avoid find_tycon panic if datacon is not in scope
ClosedPublic

Authored by adamgundry on Jun 9 2016, 10:40 AM.

Details

Summary

When using TH to splice expressions involving record
field construction, the parent datacon may not be in scope. We
shouldn't panic about this, because we will be renaming Exact
RdrNames which don't require any disambiguation.

Test Plan

new test th/T12130

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamgundry updated this revision to Diff 7919.Jun 9 2016, 10:40 AM
adamgundry retitled this revision from to Avoid find_tycon panic if datacon is not in scope.
adamgundry updated this object.
adamgundry edited the test plan for this revision. (Show Details)
adamgundry added reviewers: austin, bgamari.
adamgundry updated the Trac tickets for this revision.
bgamari accepted this revision.Jun 9 2016, 11:25 AM
bgamari edited edge metadata.

Yes, this looks right to me. Thanks!

This revision is now accepted and ready to land.Jun 9 2016, 11:25 AM
This revision was automatically updated to reflect the committed changes.