Replace hand-written Bounded instances with derived ones
ClosedPublic

Authored by RyanGlScott on Jun 3 2016, 2:48 PM.

Details

Summary

The spiritual successor to D2291, since deriving Bounded instances
in GHC.Enum wasn't possible prior to changes made in that Diff.

This Diff finds every manually implemented Bounded instance in base that is
completely equivalent to the derived instances, and replaces it.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RyanGlScott retitled this revision from to Replace hand-written Bounded instances with derived ones.Jun 3 2016, 2:48 PM
RyanGlScott updated this object.
RyanGlScott edited the test plan for this revision. (Show Details)
RyanGlScott added reviewers: hvr, austin, bgamari.
RyanGlScott added a subscriber: rwbarton.
This revision is now accepted and ready to land.Jun 4 2016, 4:16 PM
hvr added a comment.Jun 4 2016, 4:46 PM

@austin what happened to that hallucinating parrot of approval? :-)

hvr accepted this revision.Jun 4 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.
austin added a comment.Jun 4 2016, 5:08 PM
In D2301#67046, @hvr wrote:

@austin what happened to that hallucinating parrot of approval? :-)

the parrot of approval and the seal of approval are not in competition, everyone's a winner!

parrot