testsuite: Mark broken tests on powerpc64le
ClosedPublic

Authored by trommler on Jun 1 2016, 11:37 AM.

Details

Summary

Mark all failing tests that have a ticket for powerpc64
as broken. Most of these failures are due to the lack of linker
support in the runtime system.

Test Plan

validate on powerpc and AIX

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trommler retitled this revision from to testsuite: Mark broken tests on powerpc64le.Jun 1 2016, 11:37 AM
trommler updated this object.
trommler edited the test plan for this revision. (Show Details)
trommler added reviewers: hvr, erikd, austin, bgamari.
trommler updated the Trac tickets for this revision.
hvr added a comment.Jun 1 2016, 12:08 PM

there's a good chance this applies to AIX/ppc32 as well;

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

req_interp is sometimes used for that purpose.

hvr added a comment.Jun 1 2016, 12:20 PM
In D2289#66207, @thomie wrote:

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

req_interp is sometimes used for that purpose.

I know... and in my patch I have

# denotes tests requiring -XTemplateHaskell support in GHC
+# currently an alias to req_interp but this may change
+# at some point, if GHCi & TH support become non-synonmous
+req_th = req_interp

=)

trommler added a comment.EditedJun 1 2016, 1:34 PM
In D2289#66206, @hvr wrote:

there's a good chance this applies to AIX/ppc32 as well;

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

TH and GHCi work on 64-bit Linux when using dynamic libraries. There are only a few tests that exercise the RTS linker and only those tests are marked.

And yes, these tests would be broken on AIX too because we do not have XCOFF support in rts/Linker.c at all.

austin accepted this revision.Jun 1 2016, 2:59 PM

Maybe there should just be a consolidated when_ppc64 conditional. But this otherwise looks fine to me since it just marks the Linker.c tests specifically; I'd wait on @hvr for any AIX followups.

This revision is now accepted and ready to land.Jun 1 2016, 2:59 PM
This revision was automatically updated to reflect the committed changes.