Always use native-Haskell de/encoders for ASCII and latin1
ClosedPublic

Authored by thomie on May 24 2016, 10:05 AM.

Details

Summary

This fixes test encoding005 on Windows (Trac #10623).

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomie retitled this revision from to Always use native-Haskell de/encoders for ASCII and latin1.May 24 2016, 10:05 AM
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie added a reviewer: hvr.
thomie updated this revision to Diff 7721.May 24 2016, 10:08 AM

Fix typo

thomie added inline comments.May 24 2016, 10:10 AM
libraries/base/GHC/IO/Encoding.hs
261

mkIconvEncoding already has a reference to Trac Trac #10298, so I removed the comment below.

bgamari accepted this revision.May 24 2016, 11:55 AM

This looks sensible to me. I'm still a bit concerned that we might get this encoding business wrong, but not having a concrete example of breakage I can't really complain.

Thanks for handling this, @thomie!

libraries/base/GHC/IO/Encoding.hs
281

Thanks for adding these.

This revision is now accepted and ready to land.May 24 2016, 11:55 AM
austin accepted this revision.May 24 2016, 12:30 PM

Yeah, I'm always vaguely scared of such changes because encoding is so complex, but I'll buy it since it's mostly fixing the test suite.

This revision was automatically updated to reflect the committed changes.